jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > FlatpakBackend.cpp:614 > > - AppStream::Component appstreamComponent(metadata.component()); > - FlatpakResource *resource = new > FlatpakResource(appstreamComponent, flatpakInstallation, this); > + const QString fnDesktop = pathApps + name + > QLatin1String(".desktop"); > This will break for apps which .desktop file name doesn't match flatpak ref name. Also you can filter out runtimes and .Locale resources before you get here to avoid errors. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7796 To: apol, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart