graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed.
Now it looks good to me! What I would like to see is unit tests for all of that. This should be fairly simple as the tests are prepared to be run for different kind of shell surfaces. Many tests already have a _data method where it is set to be run for wl_shell and xdg_shell_unstable_v5. This should be easy to be extended for additional v6. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6591 To: mart, #plasma, graesslin, davidedmundson Cc: mart, graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
