broulik added inline comments.
INLINE COMMENTS
> ResultDelegate.qml:50
> + Accessible.name: displayLabel.text
> + Accessible.description: i18n("%1, in category %2",
> subtextLabel.text.length > 0 ? subtextLabel.text : " ", ListView.section)
> property bool __pressed: false
So we end up with " , in category foo" if subtextLabel is empty?
> ResultDelegate.qml:246
> + Accessible.name: modelData.text
> + Accessible.description: ""
> checkable: checked
Not needed?
> ResultDelegate.qml:249
> checked: resultDelegate.activeAction === index
> + focus: resultDelegate.activeAction === index
>
I don't understand this focus stuff at all but if it works..
> ResultsView.qml:140
> + if (currentIndex == 0) {
> + listView.nextItemInFocusChain(false).forceActiveFocus();
> + return;
Can we perhaps bind the "isCurrentItem" to activeFocus instead of doing this in
addition to incrementing/decrementing the index?
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D7766
To: mart, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
