pekkah created this revision. pekkah added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY The patch partially fixes an issue where all logout-related buttons are colored as black. Issue: Current logout screen uses a black background which renders blackish logout-related buttons and icons difficult to read for an user. Solution: This patch changes color of logout-related buttons and texts to white so they can easily be seen in the logout view which uses black as background color. The trick here is use contrary colors which improves the user experience. Todo: This patch does not fix an issue which regards to user icon and user name. In code, they are combined into one element. Currently, if we change color of the element to white, a custom user icon is filled with white as well. If default KDE icon is used, the issue exists but is not so visible because the icon element itself is partially a transparent element and only opaque parts are filled with white. Solution here would be to use user name as a separate element so it can be colored individually, and possibly make some code changes into file "/lookandfeel/contents/components/UserDelegate.qml" where the icon style is defined. Currently, user name and user icon are not re-colored to white. So this patch is more or less a partial implementation/fix. Unfinished code is somewhat commented out in the patch file but can be used later on if needed. TEST PLAN This patch changes the colors as defined in summary. No side effects seen so far. Using the patch requires compiling plasma-workspace package from source. The patch has been tested on the latest plasma-workspace package version available on Arch Linux (5.10.5-2) which has been compiled from source using a slightly customised PKGBUILD (added the patch file into source list) available on Arch Linux Package Repository: https://git.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/plasma-workspace Without the patch, the issue is not fixed. This behavior has been tested & confirmed before the patch file was implemented into source code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 AFFECTED FILES lookandfeel/contents/logout/Logout.qml To: pekkah, #plasma_workspaces, #plasma Cc: pekkah, #plasma_workspaces, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
