broulik added inline comments. INLINE COMMENTS
> hein wrote in ConfigGeneral.qml:123 > This isn't OK - it needs to revert to the actual config default. Some distros > change it to their branded icon and are very keen on wanting to override > specifically the default rather than pre-setting a deviation. That's one > reason why the old config format had cfg_icon and otherwise used > cfg_useCustomButtonImage (while your approach here is to migrate everyone to > cfg_icon by setting cfg_useCustomButtonImage to false when the UI is used). we could add a `Q_INVOKABLE QVariant defaultValue()` to KDeclarative `ConfigPropertyMap` so we could query this, like we already have an `bool isImmutable()` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7469 To: dvratil, #plasma Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
