graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY The overlay window is only needed for the X11 based compositors. Given that it is better suited in the X11 platform. Unfortunately it is not possible to completely move it into the platform plugin as it is still referenced in KWin core (e.g. SceneXRender). Due to that the OverlayWindow in KWin core is turned into a pure virtual class with the implementation being moved into the plugin. The platform API gains a new virtual factory method which is only implemented in the X11 platform. TEST PLAN Compiles REPOSITORY R108 KWin BRANCH overlaywindow-to-platform REVISION DETAIL https://phabricator.kde.org/D7193 AFFECTED FILES overlaywindow.cpp overlaywindow.h platform.cpp platform.h plugins/platforms/x11/common/eglonxbackend.cpp plugins/platforms/x11/standalone/CMakeLists.txt plugins/platforms/x11/standalone/glxbackend.cpp plugins/platforms/x11/standalone/overlaywindow_x11.cpp plugins/platforms/x11/standalone/overlaywindow_x11.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h scene_xrender.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
