cfeck added inline comments. INLINE COMMENTS
> graesslin wrote in client.cpp:1428 > I'll keep the second copy nevertheless. After all this mess with Qt 5 > transition I don't trust Qt in the area of QString from char array. > > I rather have here a copy too much, which won't matter, then a potential > breakage when going to Qt 6. If Qt6 would introduce UTF-8 encoded QString (so that QString::fromUtf8() would no longer need to create a new array), then you can expect all Qt software to break. QString::fromUtf8() is used nearly everywhere. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7046 To: graesslin, #kwin, #plasma Cc: cfeck, anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
