davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept seems fine.
I'm possibly wrong, but instead of the new set couldn't you
if (appDataCache.contains(window) && appDataCache[window].icon.isValid())
it has the advantage that it can't go out of sync, and that (if written well)
we could avoid another hash lookup
INLINE COMMENTS
> xwindowtasksmodel.cpp:337
> + wipeAppDataCache = true;
> + changedRoles << Qt::DecorationRole;
> + } else if (!changedRoles.contains(Qt::DecorationRole)) {
we potentially end up with two DecorationRole changes here
we should remove this line
and the "else" in the next one.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7092
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
