davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
From what I can tell this achevies nothing. (not that it'll do any harm) > The constexpr specifier declares that it is possible to evaluate the value of the function or variable at compile time. The only usage currently: const xcb_render_directformat_t *direct = XRenderUtils::findPictFormatInfo(format); const int red_bits = bitCount(direct->red_mask); There's no way that can be calculated at compile time. REVISION DETAIL https://phabricator.kde.org/D6785 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas