bruns added inline comments.
INLINE COMMENTS
> fstabstorageaccess.cpp:48
>
> + const QStringList &options = FstabHandling::options(device->device());
> + // GVFS by default doesn't show devices outside of /media, $HOME (and
> some other locations)
Another useless use of const QList<T>&, FstabHandling returns a detached list.
Even if it were not detached, contains() would not detach.
> fstabstorageaccess.cpp:52
> + // only x-gvfs-hide is honored here.
> + m_isIgnored = options.contains(QLatin1String("comment=x-gvfs-hide"));
> +
According to the linked udisk2 documentation, this should be a plain
"x-gvfs-hide", scrap the "comment=".
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D5034
To: broulik, #plasma, dhaumann, dfaure
Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
