davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY The notification dialog height is based on the implicit height of mainLayout. Main layout would shift depending on whether we were showing the icon on the left. When we hide a dialog we set the root item to invisible, this changes the effective visibility of these images, which in turn changes the width of the main layout and therefore the implicit height. This patch changes comparing visibility of the icon to comparing if it's null which is persistent. TEST PLAN Showed an notification Confirmed the implicitHeight stayed the same in gammaray Tested both with a KDE notification with an icon and notify-send Marco can you see if it helps your issue, without the part of your p-f patch that changes rootItem visibility. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6237 AFFECTED FILES applets/notifications/package/contents/ui/NotificationItem.qml To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
