davidedmundson added a comment.
Comments for Marco: INLINE COMMENTS > xdgshell_interface.h:80 > > + void ping(); > + We need the serial Ids here, otherwise it's not very usable; especially as the pong doesn't have an elapsed time. A kjob like API wrapping this might be perfect for here? > xdgshell_interface_p.h:41 > + quint32 pingSerial = 0; > + QScopedPointer<QTimer> pingTimer; > + I don't understand this timer, all it's used for is for making us not emit a pong if it comes in after a timeout? REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
