subdiff updated this revision to Diff 14753.
subdiff marked 4 inline comments as done.
subdiff added a comment.
Diff update:
- Fixed inline comments
- Fixed @mart's comment
- Labels aligned to the right
- Slight renaming of labels ("Sunrise/set ends" -> "and ends")
> Make sure you test with --reverse, I think your activator checkbox will be
broken
You're right, but I'm just using the text attribute of QQC's CheckBox, so I'm
not sure if I should write a workaround here or just wait for upstream to fix
it. The visual fallout is minimal and the checkbox still usable:
F3760241: Rw1t2w7 - Imgur.png <https://phabricator.kde.org/F3760241>
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5932?vs=14747&id=14753
REVISION DETAIL
https://phabricator.kde.org/D5932
AFFECTED FILES
CMakeLists.txt
kcms/CMakeLists.txt
kcms/nightcolor/CMakeLists.txt
kcms/nightcolor/kcm.cpp
kcms/nightcolor/kcm.h
kcms/nightcolor/kcm_nightcolor.desktop
kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
kcms/nightcolor/package/contents/ui/NumberField.qml
kcms/nightcolor/package/contents/ui/TimeField.qml
kcms/nightcolor/package/contents/ui/TimingsView.qml
kcms/nightcolor/package/contents/ui/main.qml
kcms/nightcolor/package/metadata.desktop
To: subdiff, #plasma
Cc: mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
