mart added inline comments. INLINE COMMENTS
> davidedmundson wrote in colorscm.cpp:134 > What is this about? > blocking signals is a sign of something else being seriously wrong. this is just copied from the old revision before the current entry was removed... it can be safely removed as i prefer anyways that it highlights the actual current theme (like breeze) instead of the fake entry named "current" > davidedmundson wrote in colorscm.cpp:458-459 > If the current design is for saving to be handled by signaling from the > dialog to the KCM which does the actual saving. You should handle apply in > the same way. no, the saving is handled completely in the editor dialog. this reloads the tiny previews, that is anyways a good thing to do in case of applied as well REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5411 To: mart, #plasma Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
