leinir created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This avoids numerous crashes when using the keyboard navigation in Discover during searches. It would seem that, without this, we occasionally (which during a search with auto-updating results means regularly) send key events to a component which is not yet ready to receive them... It would be nice if this were caught by Qt, but i guess that might be a little expensive to do generically. nb: i would like this to be a typesafe comparison, but... yay qml ;) TEST PLAN Before: Discover crashed a lot during searches Now: Discover crashes /way/ less during searches :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5408 AFFECTED FILES src/controls/ScrollablePage.qml To: leinir, apol, #kirigami, mart Cc: plasma-devel, apol