mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  ...provided the usage of `uiLanguages[0]` is safe like this.

INLINE COMMENTS

> DaysCalendar.qml:315
>                  height: daysCalendar.cellHeight
> -                text: Qt.locale().dayName(calendarBackend.firstDayOfWeek + 
> index, Locale.ShortFormat)
> +                text: 
> Qt.locale(Qt.locale().uiLanguages[0]).dayName(calendarBackend.firstDayOfWeek 
> + index, Locale.ShortFormat)
>                  font.pixelSize: Math.max(theme.smallestFont.pixelSize, 
> daysCalendar.cellHeight / 3)

Now I'm not entirely sure but can the `uiLanguages[0]`
possibly return null?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5345

To: drosca, #plasma, mck182
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to