broulik added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:455
> +                    top: frameLoader.top
> +                    leftMargin: root.useListViewMode ? (icon.x + (icon.width 
> / 2)) - (width / 2) : 0
> +                    topMargin: root.useListViewMode ? (icon.y + (icon.height 
> / 2)) - (height / 2)  : 0

Can you verify this (`icon.x` in conjunction with auto-mirroring left anchor) 
works fine in RTL mode?

> FolderItemDelegate.qml:459
> +
> +                width: implicitWidth
> +                height: implicitHeight

Shouldn't be neccessary

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5309

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to