graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land.
Apart from the two minor issues, looks good to me :) INLINE COMMENTS > markg wrote in screen.cpp:79 > c cast... no no no! > static_cast<qreal>(...) is the cast needed at all? It should be implicitly casted from int to real, shouldn't it? BRANCH scaling_final REVISION DETAIL https://phabricator.kde.org/D5172 To: davidedmundson, #plasma, graesslin Cc: graesslin, markg, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
