apol added a comment.
In https://phabricator.kde.org/D5088#96296, @davidedmundson wrote: > I'm confused. > > If you're generating the qmltypes with the ecm command, why are they in the diff? Good point. We can't generate them at runtime. Here's how they put it in Qt: # plugins.qmltypes is used by Qt Creator for syntax highlighting and the QML code model. It needs # to be regenerated whenever the QML elements exported by the plugin change. This cannot be done # automatically at compile time because qmlplugindump does not support some QML features and it may # not be possible when cross-compiling. Biggest issue is that you need a set up install prefix to generate the plugins as it expects the prefix structure. Also it needs to load the plugin so it will certainly be a problem on certain setups. We could find a workaround where it gets to be generated at build-time, but it will feel off. Here at least we're doing the same Qt does with their `plugins.qmltypes` files. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
