graesslin added a comment.

  In https://phabricator.kde.org/D5078#95680, @mart wrote:
  
  > In https://phabricator.kde.org/D5078#95679, @graesslin wrote:
  >
  > > So if I understand correctly on the paddingChanged we do not need to 
repaint, you are only interested in the update of the 
m_visibleRectBeforeGeometryUpdate? In that case I suggest to update it whenever 
the shadow changes.
  >
  >
  > yes.
  >  so just update that property in a lambda without the actual call to 
addRepaintDuringGeometryUpdates? (and addLayerRepaint)
  
  
  would be better in my opinion. That would make it more clear what happens and 
is also more correct. After all the idea of the variable is to include the 
geometry including the shadow and it doesn't get updated when the shadow 
changes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5078

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to