ivan updated this revision to Diff 12174. ivan retitled this revision from "Per-activity favorites (WIP)" to "Per-activity favorites (Final?)". ivan edited the test plan for this revision. ivan added a comment.
This should be it. Needs to be reviewed as soon as possible, so that we can detect all the bugs, regressions etc. before the release. The patch requires KF5 5.32. Dropping at a specified index now works, and the old favourites are transitioned to the new model - the old favs are set to be favourites for all activities. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3805?vs=12171&id=12174 REVISION DETAIL https://phabricator.kde.org/D3805 AFFECTED FILES CMakeLists.txt applets/kicker/CMakeLists.txt applets/kicker/package/contents/code/tools.js applets/kicker/package/contents/ui/ActionMenu.qml applets/kicker/plugin/computermodel.cpp applets/kicker/plugin/computermodel.h applets/kicker/plugin/favoritesmodel.cpp applets/kicker/plugin/favoritesmodel.h applets/kicker/plugin/kastatsfavoritesmodel.cpp applets/kicker/plugin/kastatsfavoritesmodel.h applets/kicker/plugin/kickerplugin.cpp applets/kicker/plugin/placeholdermodel.cpp applets/kicker/plugin/placeholdermodel.h applets/kicker/plugin/recentusagemodel.cpp applets/kicker/plugin/rootmodel.cpp applets/kicker/plugin/rootmodel.h applets/kicker/plugin/simplefavoritesmodel.cpp applets/kicker/plugin/simplefavoritesmodel.h applets/kicker/plugin/systemmodel.cpp To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
