broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.

Just noticed I hadn't set my sails for adventure when I first saw this. Let's go with this I'd say.

INLINE COMMENTS

    <entry name="TransitionAnimationDuration" type="int">
      <label>Fade Transition Animation  (ms)</label>
      <default>1000</default>

There's two spaces

View Inlinemain.qml:191

                //use configured duration if animations are enabled
                duration: units.longDuration && wallpaper.configuration.TransitionAnimationDuration
            }

This works in JS but I'd prefer it to be more explicit

units.longDuration > 0 ? wallpaper.configuration.TransitionAnimationDuration : 0


(says the one who prefers foo || bar over foo ? foo : bar :D)

REPOSITORY

R120 Plasma Workspace

BRANCH

master

REVISION DETAIL

https://phabricator.kde.org/D4370

EMAIL PREFERENCES

https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4370: Set a longer wallpaper transition time

Reply via email to