| broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. | View Revision
REVISION SUMMARY
When an icon failed to load, show the "unknown" icon instead of a gap.
We don't want to check for icon availability in the model for performance reasons but only once the delegate is created (when it comes into view).
TEST PLAN
GridView doesn't recycle items, so when the item goes out of view and comes back, it will essentially re-evaluate this.
Downside, if we failed to load an icon but have a previewer, we won't show the preview now. I don't think that's a common scenario - how come we can have a previewer for a format that is so exotic that we don't even have an icon for it?
Situations for when this can happen:
- .desktop file with rubbish Icon or not installed icon
- icon for mimetype for which we don't have an icon (some exotic mimetypes, kio iirc always sets icon name to one deduced from the mime type)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
AFFECTED FILES
containments/desktop/package/contents/ui/FolderItemDelegate.qml
EMAIL PREFERENCES
To: broulik, Plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
