Zren added inline comments.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:122
> Do we really need this (we certainly don't need the `parent.flat` part)? It 
> doesn't seem to change the icon at all.

Not really. Just wanted to have consistent code with ToolButtonStyle, but I 
already had to change `control` => `parent` so might as well remove it. 
ToolButton is basically a `flat: true` Button so that part will always be 
`!true`/`false`.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4845

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, subdiff, drosca, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to