davidedmundson added inline comments. INLINE COMMENTS
> framesvg.cpp:804 > const QLatin1Char s('_'); > - return QString::number(frame->enabledBorders) % s % > QString::number(size.width()) % s % QString::number(size.height()) % s % > QString::number(q->scaleFactor()) % s % > QString::number(q->devicePixelRatio()) % s % prefixToSave % s % > q->imagePath(); > + return QString::number(frame->enabledBorders) % s % > QString::number(size.width()) % s % QString::number(size.height()) % s % > QString::number(q->scaleFactor()) % s % > QString::number(q->devicePixelRatio()) % s % prefixToSave % s % > frame->imagePath; > } I don't understand this and the FrameData part of this change. q->imagePath() will still always be correct as before, you still set that in setImagePath() regardless of whether we are blocking updates or not. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol