broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land.
> Also unlike Array.concat Array.splice alters the current array, we don't want to create a new var. The return value of splice is btw the items that were removed. INLINE COMMENTS > ContextMenu.qml:382 > }; > })(activityId)); > } You could have passed the correct menuItem in here just like it's already done correctly with activityId REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
