markg reopened this revision. markg added a comment. This revision is now accepted and ready to land.
Hmm, i don't know if this is the appropriate way in a phabricator workflow. But this does reach exactly those involved in this change which is what i intent. On to the point. When this change just appeared i looked at it. At the video, the code and had an impression of: "Ohh, that's a rather nice improvement! Nicely done!" But now that we have a plasma version with this code in it i do have a few remarks. Nothing serious, just some minor but notable details. - The tooltips of the task manager now look out of place compared to the tooltips in other areas of a panel (think of the clock, kickoff, etc.. everything non task manager). - The tooltips clearly have a different style compared to other tooltips. The text is much closer to the corners. The issues are easily fixable. It just needs to follow the margins that the other tooltips use. Or the other tooltips have to be adjusted, either way makes it consistent again. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #vdg, hein, #plasma Cc: markg, broulik, anthonyfieroni, hein, colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
