subdiff accepted this revision.
subdiff added a reviewer: subdiff.
subdiff added a comment.
This revision is now accepted and ready to land.
Didn't find any obvious issues in code plus tested it on X and Wayland.
INLINE COMMENTS
> keyboard_input.cpp:686
> m_input->processSpies(std::bind(&InputEventSpy::keyEvent,
> std::placeholders::_1, &event));
> + if (!m_inited) {
> + return;
Somewhat unrelated to this diff, but can't we get rid of all these `m_inited`
conditions by setting up LibInput via `InputRedirection::setupLibInput()` and
connecting the functions in KeyboardInputRedirection only after
`m_keyboard->init()` and so on in `InputRedirection::setupWorkspace()` were
called?
REPOSITORY
R108 KWin
BRANCH
modifier-only-shortcuts
REVISION DETAIL
https://phabricator.kde.org/D4578
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma, #kwin, subdiff
Cc: subdiff, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
