broulik created this revision. broulik added reviewers: lesliezhai, jriddell, Plasma. broulik set the repository for this revision to R467 K3b. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY In https://phabricator.kde.org/R467:cf01ff3159dbddb97e0e67246dee16441a64984a this broke by randomly using QSharedPointer in the wrong way. There was only this one item being referenced, once it fell out of scope it got deleted, and then by the time the event loop returned and the queued invocation was processed, the object was already gone. Just use WA_DeleteOnClose which will clean up nicely once we're done. BUG: 375016 TEST PLAN FIXED-IN: Whatever stable branch and stuff this is in, I'll figure it out. I can now add files to K3B projects again. REPOSITORY R467 K3b REVISION DETAIL https://phabricator.kde.org/D4571 AFFECTED FILES src/projects/k3bdataurladdingdialog.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, lesliezhai, jriddell, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
