mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > BinaryClock.qml:41 > + > + Layout.minimumWidth: w1 < 20 ? 20 : w1 > + Layout.maximumWidth: Infinity this should be in gridunits? > BinaryClock.qml:45 > + > + Layout.minimumHeight: 16+(units.smallSpacing * 5) > + // Layout.maximumHeight: vertical ? Layout.minimumHeight : Infinity pretty arbitrary? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4503 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
