-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125897/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 2:24 nachm.)


Status
------

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Martin Gräßlin.


Repository: plasma-workspace


Description
-------

This fixes the list only showing one line of text instead of the supposed 
maximum of 3 lines.

I'm unsure about the "m" modifier, however. With it, it highlights leading and 
trailing whitespace on any line which can be nice but also somewhat distracting 
depending on what you copied. On the other hand, only doing it for the first 
line (as is now but wasnt apparent because we only showed one line) is also 
strange. Especially when you use spaces rather than line breaks you can get 
quite a few "space" indicators.. (I can split the patch though, broken 
multiline display is definitely a bug)


Diffs
-----

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 

Diff: https://git.reviewboard.kde.org/r/125897/diff/


Testing
-------

Works


File Attachments
----------------

With multiline modifier
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png
Without (currently)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png


Thanks,

Kai Uwe Broulik

Reply via email to