broulik created this revision. broulik added reviewers: Plasma, graesslin, dfaure. broulik set the repository for this revision to R295 KCMUtils. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY This disconnects the connection when the window goes away otherwise it might crash. TEST PLAN Fixes kwin effects kcm crashing in System Settings with https://phabricator.kde.org/D4492 where that signal is actually emitted. The effects KCM doesn't really update its colors but I think that is because the kwin effects kcm doesn't use SystemPalette but takes care of the colors manually REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D4493 AFFECTED FILES src/kcmoduleqml.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graesslin, dfaure Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
