davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY ::createMenu sometimes creates a new menu, sometimes returns a pointer to a menu from libdbusmenu that we shouldn't delete. This patch makes any newly created menu delete itself on closure. It then shuffles some code so that we only call createMenu after doing checks. TEST PLAN Ran in compact mode, clicked menu a few times Ran in full mode, clicked a menu a few times REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4393 AFFECTED FILES applets/appmenu/lib/appmenuapplet.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
