apol added inline comments.
INLINE COMMENTS
> killrunner.cpp:186
> +
> + int returnCode = KProcess::execute(QStringLiteral("kill"), args);
>
If what you want is just to fix the leak putting it in the stack would be the
obvious thing to do.
OTOH, we don't really want it to block, maybe you could turn it into a lambda
that calls the KAuth fallback? (or a slot).
Then deleting would mean to connect the finished to deleteLater.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4383
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
