drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY There is no difference for normal streams where setVolume and setMute are two different API calls, but it fixes issue with setting volume to 0 for ext-stream-restore streams (notification sounds) where there is only one API call to change all stream properties. TEST PLAN Moving volume slider to 0 for Notification sounds in KCM now correctly sets the volume to 0 and mute it. Functionality with other streams is unchanged. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mute-eventstream REVISION DETAIL https://phabricator.kde.org/D4138 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas