----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/#review102013 -----------------------------------------------------------
holidays/plan2/holiday_pl_pl (line 34) <https://git.reviewboard.kde.org/r/129736/#comment68223> "Please see how I did it for an Italian (new) public holiday, "Festa della Repubblica", see both lines: https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n27 https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n80 holidays/plan2/holiday_pl_pl (line 45) <https://git.reviewboard.kde.org/r/129736/#comment68221> IIRC there is no specific way right now unfortunately. If you say <holidayname> and most people perceive it as that date, it would be fine to leave it as it is. At most you can add a note like "(Roman Catholic Church)" (translated of course) holidays/plan2/holiday_pl_pl (line 101) <https://git.reviewboard.kde.org/r/129736/#comment68222> uhm, are those really required? It should be better to add the calculation of the date in the library. But that can take ages, so this is more a note. - Luigi Toscano On Gen. 1, 2017, 9:38 a.m., Roman Standzikowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129736/ > ----------------------------------------------------------- > > (Updated Gen. 1, 2017, 9:38 a.m.) > > > Review request for Plasma. > > > Repository: kholidays > > > Description > ------- > > The patch contains updated holidays for Poland. This would fix bug > https://bugs.kde.org/show_bug.cgi?id=365153. > > > For general information about polish holidays (especially the ones we do not > work in Poland), see: > > - see https://en.wikipedia.org/wiki/Public_holidays_in_Poland > - polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU20150000090 > > Changes: > - [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a > public holiday, since 2011 (see > https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland) > - '?ledzik' is not really a religious holiday, this is just the last day of > carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no > special religious celebrations at this day in Poland > - moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure > what is the different between 'civil' and 'cultural' holidays, but it seems > no sense to have just the Valentine's Day in cultural and nothing else there > - 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday > (see https://en.wikipedia.org/wiki/All_Souls%27_Day, > https://pl.wikipedia.org/wiki/Zaduszki) > - 'Wigilia' is also a religious holiday (see > https://en.wikipedia.org/wiki/Christmas_Eve, > https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia) > - 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit > complicated; this is both Army Day and Assumption of the Blessed Virgin Mary > (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the > polish law act the Assumption is mentioned, it is now a 'public religious', > and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one > - 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan > tradition; since it is not mentioned in the polish law act, I have moved it > to civil (this day is a holiday, because it is also a second day of Easter). > I am not 100% sure about this change, any help would be welcome > - 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I > couldn't resist :) > - added 'T?usty Czwartek' ('Fat Thursday' - > https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no > special religious celebrations this day, I have marked it as civil > - added 'Dzie? Górnika' ('Miners Day' - > https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional > celebration held in mining areas of Poland > - added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - > https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every > school > - renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see > https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj) > - polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition > - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. > Andrew's Day'; moved to 29th November, as 30th November is already after the > feast > - daylight saving time added (same time is in the whole European Union) - > 'Czas letni', 'Czas zimowy' > - added 'Prima Aprilis' ('April Fools' Day') > - added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see > https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci) > - added 'Dzie? Zwyci?stwa' ('Victory Day' - see > https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa) > - added equinoxes and solstices > - added comment about polish school holidays > > > Diffs > ----- > > holidays/plan2/holiday_pl_pl 54d56ac > > Diff: https://git.reviewboard.kde.org/r/129736/diff/ > > > Testing > ------- > > > Thanks, > > Roman Standzikowski > >
