davidedmundson added inline comments. INLINE COMMENTS
> shellcorona.cpp:226 > + KDirWatch::self()->addFile(configFile); > + connect(KDirWatch::self(), &KDirWatch::dirty, this, > &ShellCorona::updateConfiguration); > + connect(KDirWatch::self(), &KDirWatch::created, this, > &ShellCorona::updateConfiguration); KDirWatch::self() is a singleton consider the case where two things use the singleton, you use it to monitor ~/.plasmarc and another uses it to monitor /tmp/asdfadf this signal will be emitted in both cases. You should use the parameter in the signal to do some filtering. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: davidedmundson, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
