graesslin added a comment.
I'd still love to see autotests for it, otherwise looks good. Just two very
minor issues spotted.
INLINE COMMENTS
> appmenu.cpp:98
> +{
> + qDebug() << "SHOW APP MENU" << p << actionId;
> + m_appmenuInterface->showMenu(p.x(), p.y(),
> c->applicationMenuServiceName(),
> QDBusObjectPath(c->applicationMenuObjectPath()), actionId);
That one should be removed ;-)
> appmenu.h:29
> +// xcb
> +#include <xcb/xcb.h>
> +
I think you can remove this include. At least I don't see any xcb usage.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, andreaska, sebas
