broulik created this revision. broulik added reviewers: Plasma, davidedmundson. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When comparing two applets that don't have an order yet, we would fall through to the regular sorting algorithm which would return "(-1) - (-1)", ie. -2 and then add the applets the wrong way round. This happens when adding a new default panel. Instead, take into account the relative order within "plasmoid.applets" TEST PLAN Added new default panel, order is correct. Verified that applets not in AppletOrder will still be sorted last as before Fixes regression introduced in https://phabricator.kde.org/D3834 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3982 AFFECTED FILES containments/panel/contents/code/LayoutManager.js EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas