----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/ -----------------------------------------------------------
(Updated Dec. 31, 2016, 10:56 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma, David Faure and Friedrich W. H. Kossebau. Changes ------- Submitted with commit 87b27476cc8a3865994da066ce06a3e836462719 by Albert Astals Cid to branch Plasma/5.8. Repository: plasma-integration Description ------- 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the save dialog appear as Open dialog. Simplify the code in that commit so it does not regress anymore. Comes with a unit test (argably a bit meh since it could loop forever if the dialog does not show, but i guess it is good if that happens too :D) Diffs ----- autotests/kfiledialog_unittest.cpp 47a5543 src/platformtheme/kdeplatformfiledialoghelper.cpp 990b983 Diff: https://git.reviewboard.kde.org/r/129732/diff/ Testing ------- New test fails without the patch, works with it. Kate Save As dialog no longer shows as Open dialog. Thanks, Albert Astals Cid
