----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129436/#review101010 -----------------------------------------------------------
Ship it! couldn't be worth to call useCache() if the plugininfo isn't valid, in that case would tickle down reevaluating of themeMetadataPath? (or maybe just resetting it to empty string) - Marco Martin On Nov. 19, 2016, 10:41 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129436/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2016, 10:41 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > settingsFileChanged is called if the plugin metadata file changes, and > reloads the theme if the version changes. > > However, if the metadata file now doesn't exist we need to check before > calling .version() otherwise it will assert. > > If it doesn't exist, we want to reload the theme so that it will load > the correct thing. > > BUG: 372651 > > > Diffs > ----- > > src/plasma/private/theme_p.cpp 0f3662e8f58c8cccdf9af2b8cf6878f5f0cef10b > > Diff: https://git.reviewboard.kde.org/r/129436/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
