----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128526/ -----------------------------------------------------------
(Updated Nov. 17, 2016, 11:37 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Andreas Kainz. Changes ------- Submitted with commit 2d8b2ec7b1c96ffc232db6dcd919e449a6c8b063 by Jaroslaw Staniek to branch master. Repository: breeze-icons Description ------- Make BINARY_ICONS_RESOURCE ON by default. Otherwise packagers will not create packages with breeze-icons.rcc. Let them possible create split packages - 1 with icon files and 1 with the rcc file. Also our Jenkins fails to create the file, apps have no way to add dependency on breeze-icons "with rcc", there's just breeze-icons that we can depend on. Example failure: https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console Diffs ----- CMakeLists.txt c0623ca Diff: https://git.reviewboard.kde.org/r/128526/diff/ Testing ------- breeze-icons now installs the .rcc file. Thanks, Jarosław Staniek
