graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in input.cpp:488
> Can this happen? You check for buttons being NoButton and then for button 
> being RightButton?

Yes of course. QMouseEvent::buttons contains the buttons currently hold. So we 
test that no buttons are currently pressed. And QMouseEvent::button contains 
the button which generated the event.

So this tests that the right mouse button was released and no further button is 
hold.

> broulik wrote in input.cpp:1409
> Where is that being cleaned up?

like all InputEventFilters in InputRedirection::~InputRedirection

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Reply via email to