broulik added inline comments.

INLINE COMMENTS

> x11eventfilter.cpp:58
> +    }
> +    return m_eventTypes.first() == XCB_GE_GENERIC;
> +}

m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector<int> 
constructor?

REPOSITORY
  rKWIN KWin

BRANCH
  x11-event-filter-multiple-types

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Reply via email to