graesslin added inline comments. INLINE COMMENTS
> drm_output.cpp:177-228 > + switch (connector->connector_type) { > + case DRM_MODE_CONNECTOR_VGA: > + connectorName = QStringLiteral("VGA"); > + break; > + case DRM_MODE_CONNECTOR_DVII: > + connectorName = QStringLiteral("DVI-I"); > + break; I would prefer a static hashmap instead of a long switch statement. Similar to how it is done in Weston. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3341 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas