mart added a comment.
In https://phabricator.kde.org/D3319#61870, @fvogt wrote: > A quick question: This changes what the ScreenPool constructor does, are there any potential users of ScreenPool that now miss a call to ->load(), as it was done implicitly before? Wouldn't it be safer to call load() in the constructor as well? shellcorona should be the only user so far, so that shouldn't be an issue even just constructing screenpool later, should be fine INLINE COMMENTS > cfeck wrote in screenpool.cpp:37 > This line does nothing. What was the intention? i guess was to reset it, so would be m_primaryConnector.clear() or something? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3319 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, rwooninck, fvogt, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
