----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128626/#review100686 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Aug. 8, 2016, 6:59 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128626/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 6:59 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > - in test we actually want to use it for the purposes of the test > - in kpackagetool we can use the new cryptographicHash func directly > > > Diffs > ----- > > autotests/plasmoidpackagetest.cpp 9b1cadec2296132c2ec4a7fc8142ec34cb3381f1 > src/kpackagetool/kpackagetool.cpp 4f5b78761ced760f081b3449afc67790d25138a2 > > Diff: https://git.reviewboard.kde.org/r/128626/diff/ > > > Testing > ------- > > builds & tests pass (sans appstream, which I guess I didn't break :P) > > > Thanks, > > Harald Sitter > >
