antlarr added inline comments. INLINE COMMENTS
> mart wrote in image.cpp:196 > dead code The commented out qDebug a couple of lines below shows that variable (when uncommented). Should I remove it from the qDebug line below? or just keep both? (the same for the case above) > mart wrote in testfindpreferredimage.cpp:90 > good that a test has been added! > but instead of doing all of this manually, couldn't it use qt autotest stuff, > qcompare, qtest etc? I never used QTest before and I thought about that but preferred to do it as fast as possible. I guess I'll have to write it anyway :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
