> On 十月 17, 2016, 10:38 a.m., Marco Martin wrote: > > should those be themed in the plasma theme? > > shouldn't them just go in the regular breeze icon theme?
I have discussed with Breeze icon team. They suggest to move these icons to plasma theme since they are mostly used in system tray/widget. - Yunhe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100083 ----------------------------------------------------------- On 十月 6, 2016, 6:03 p.m., Yunhe Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > ----------------------------------------------------------- > > (Updated 十月 6, 2016, 6:03 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > ime.svgz > > - ime-fullwidth > - ime-halfwidth > - ime-punctuation-fullwidth > - ime-punctuation-halfwidth > - ime-chinese-simplified > - ime-chinese-traditional > - ime-remind-on > - ime-remind-off > - ime-handwriting-on > - ime-handwriting-off > - ime-erbi > - ime-googlepinyin > - ime-libpinyin-pinyin > - ime-libpinyin-quanpin > - ime-libpinyin-shuangpin > - ime-pinyin > - ime-quanpin > - ime-shuangpin > - ime-sunpinyin > - ime-wubi > - ime-wubipinyin > - ime-ziranma > - ime-bopomofo > - ime-cangjie > - ime-chewing > - ime-libpinyin-bopomofo > - ime-libpinyin-chewing > - ime-rime > - ime-anthy > - ime-libkkc > - ime-libskk > - ime-hangul > - ime-unikey > - ime-emoji > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-vk-active > - fcitx-vk-inactive > - fcitx-remind-active > - fcitx-remind-inactive > - fcitx-chntran-active > - fcitx-chntran-inactive > - fcitx-fullwidth-active > - fcitx-fullwidth-inactive > - fcitx-punc-active > - fcitx-punc-inactive > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > - ... > > > Diffs > ----- > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > Screenshot_20161006_201118.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png > Spectacle.Zb3480.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/74a7126d-f917-4be0-864c-9f5f5253d448__Spectacle.Zb3480.png > > > Thanks, > > Yunhe Guo > >
