graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY A shortcut with e.g. shift+w could not be triggered as shift is considered as consumed. It transforms the keysym to an uppercase variant thus it is consumed. This change checks for the condition that shift is pressed and is the only consumed modifier. If the current keysym is a letter the shift is removed from the consumed modifier again to still support the shortcut. BUG: 370341 FIXED-IN: 5.8.2 REPOSITORY rKWIN KWin BRANCH consumed-mods-ignore-letters REVISION DETAIL https://phabricator.kde.org/D3015 AFFECTED FILES autotests/integration/globalshortcuts_test.cpp keyboard_input.cpp keyboard_input.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas